Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please stop locating tcmalloc headers via google/tcmalloc.h #396

Open
alk opened this issue Sep 14, 2024 · 2 comments
Open

Please stop locating tcmalloc headers via google/tcmalloc.h #396

alk opened this issue Sep 14, 2024 · 2 comments

Comments

@alk
Copy link

alk commented Sep 14, 2024

Describe the bug

SUBJ. This include path has been deprecated for > 10 years now. We're shipping gperftools/tcmalloc.h.

Also from quick inspection I see that you don't really need headers anyways. So consider not even bothering to locate it.

(How do I find it? I just github-searched for google/tcmalloc.h usages that aren't clearly dead; yours is first I found so far)
@TobiasDuswald
Copy link
Contributor

Sorry I have now idea what you're talking about. Can you try to explain that differently such that I understand what you mean?

@alk
Copy link
Author

alk commented Dec 4, 2024

Your cmake setup is searching for tcmalloc.h header which doesn't exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alk @TobiasDuswald