Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/v0.4.0 #66

Merged
merged 22 commits into from
Jan 27, 2024
Merged

Release/v0.4.0 #66

merged 22 commits into from
Jan 27, 2024

Conversation

CiaranOMara
Copy link
Member

@CiaranOMara CiaranOMara commented Jan 18, 2024

Added

  • Added BAM.Reader index support for BAI object (#56).
  • Added doi badge.
  • Added test to ensure EOF_BLOCK gets written.
  • Added isreversestrand.
  • Added isfirstsegment.
  • Added islastsegment.

Changed

  • Subtype from XAMReader and XAMWriter from common abstract types.
  • Subtype from XAMRecord.
  • Unified flag queries.
  • Improved Slack link.
  • Updated to use Automa v1 (#65).
  • Pointed the Unit Tests badge at the develop branch.
  • Pluralised flag.
  • Renamed ismateunmapped to isnextunmapped.
  • Renamed isreverse to isreversecomplemented.
  • Renamed isforward to isforwardstrand.
  • ispositivestrand aliases isforwardstrand.
  • isnegativestrand aliases isreversestrand.
  • Renamed ismatereverse to isnextreversecomplemented.
  • isread1 aliases isfirstsegment.
  • isread2 aliases islastsegment.

Fixed

  • Updated hts-files.md (#62).
  • Corrected the behaviour of isprimaryalignment with isprimary.

Removed

  • Moved the functionality of isprimary into isprimaryalignment.

@CiaranOMara CiaranOMara changed the base branch from develop to master January 18, 2024 03:10
Copy link
Member

@jakobnissen jakobnissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some parts of the flags.jl file needs to be gone through. It does seem a little inconsistent and arbitrary in its behaviour, documentation, and nomenclariture.

src/XAM.jl Show resolved Hide resolved
src/flags.jl Outdated Show resolved Hide resolved
src/flags.jl Outdated Show resolved Hide resolved
src/flags.jl Outdated Show resolved Hide resolved
src/flags.jl Outdated Show resolved Hide resolved
src/flags.jl Outdated Show resolved Hide resolved
src/flags.jl Outdated Show resolved Hide resolved
src/flags.jl Outdated Show resolved Hide resolved
src/flags.jl Outdated Show resolved Hide resolved
@CiaranOMara CiaranOMara force-pushed the release/v0.4.0 branch 5 times, most recently from 3e707bb to 335ab09 Compare January 22, 2024 07:33
@CiaranOMara
Copy link
Member Author

@jakobnissen, I think your comments can be resolved, and this is ready for another check. I have attempted to align the nomenclature with the SAM spec. So, it should be more consistent. Though, I'm unhappy about the method isproperpair and associated variables, as there can be more than two segments in a template - Do you have any ideas?

@CiaranOMara CiaranOMara merged commit beefc45 into master Jan 27, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants