-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/v0.4.0 #66
Release/v0.4.0 #66
Conversation
Added method for handling different bam index types.
Implements flag queries.
Fix find -> findall for headers
Fix deprecated find in header docs
- Add GitHub "annotations" - Update codecov-action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some parts of the flags.jl file needs to be gone through. It does seem a little inconsistent and arbitrary in its behaviour, documentation, and nomenclariture.
3e707bb
to
335ab09
Compare
335ab09
to
456d820
Compare
@jakobnissen, I think your comments can be resolved, and this is ready for another check. I have attempted to align the nomenclature with the SAM spec. So, it should be more consistent. Though, I'm unhappy about the method |
Added
isreversestrand
.isfirstsegment
.islastsegment
.Changed
ismateunmapped
toisnextunmapped
.isreverse
toisreversecomplemented
.isforward
toisforwardstrand
.ispositivestrand
aliasesisforwardstrand
.isnegativestrand
aliasesisreversestrand
.ismatereverse
toisnextreversecomplemented
.isread1
aliasesisfirstsegment
.isread2
aliasesislastsegment
.Fixed
isprimaryalignment
withisprimary
.Removed
isprimary
intoisprimaryalignment
.