Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move irtkVTK.h from Image to Common #2

Open
schuhschuh opened this issue Dec 12, 2015 · 6 comments
Open

Move irtkVTK.h from Image to Common #2

schuhschuh opened this issue Dec 12, 2015 · 6 comments

Comments

@schuhschuh
Copy link
Member

In my personal development branch, I moved irtkVTK.h from the Image module to Common and renamed it to irtkVtk.h (to follow naming convention of other similar files, such as irtkUmfpack.h). This issue is to remind of merging this change from my branch into master.

@schuhschuh schuhschuh changed the title Move irtkVTK.h from Geometry to Common Move irtkVTK.h from Image to Common Dec 12, 2015
@ghisvail
Copy link
Member

Any specific rationales for this change ?

@schuhschuh
Copy link
Member Author

The file is not specific to the Image module. The Common module should provide other modules with the tools to take advantage of common external libraries.

@ghisvail
Copy link
Member

Fair point. That means Common will have optional linkage to VTK.

@schuhschuh
Copy link
Member Author

Yes, the entire IRTK project always had optional linkage to VTK. There are some "core" applications that used it independently of the Image module. Maybe these can be made part of the PolyData module instead and every module that uses VTK needs to depend on this module... ? Not something I had in mind yet as the PolyData module mainly served the purpose of dealing with surface meshes (but is no longer limited to it, but point sets in general).

@ghisvail
Copy link
Member

I can't comment on the feasibility of completely encapsulating our usage of VTK. It would be a nice goal towards having IRTK as a proper library.

@schuhschuh
Copy link
Member Author

I would say that mostly depends on the effort you want to put into wrapping the essential VTK data object types such as vtkPointSet, vtkPolyData, vtkImageData, vtkDataArray, (vtkPoints -> irtkPointSet) ... other than that, all uses of the VTK algorithms is (or can be) hidden within the IRTK classes. Just the data containers need to be exchanged.

In my PolyData module implementations, I have for sake of simplicity used the VTK data types directly as class attributes and function arguments. Hence, all this would need to be replaced by IRTK proxy types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants