Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function for structural alignments via least-squares fit #5

Open
rasbt opened this issue Nov 24, 2015 · 4 comments
Open

Add function for structural alignments via least-squares fit #5

rasbt opened this issue Nov 24, 2015 · 4 comments

Comments

@rasbt
Copy link
Member

rasbt commented Nov 24, 2015

A staticmethod least-squares superposition. We could call it align and implement it with similar parameters as the rmsd function. In addition, it would be nice to have a substructure parameter for substructure alignment -- maybe accepting an iterable of residue numbers here.

@universvm
Copy link

universvm commented May 13, 2022

Hi @rasbt ,

I wonder if it'd be worth integrating a library like this one: https://github.com/charnley/rmsd rather than implementing the algorithm from scratch.

Alternatively another method could be to call biopython align the objects, save to a temp file and reload them into an array.

What do you think?

@rasbt
Copy link
Member Author

rasbt commented May 13, 2022

Sure, that makes a lot of sense. I see that the rmsd package is also under BSD licence, and we could add it to biopandas.externals (similar to how scikit-learn does it) and then modify it to our needs -- with the respective copyright notice of course & citation in the docs.

It looks like rmsd is meant as a command line tool, so we would have to adjust it a little.

Regarding biopython, that's another option, but to be honest, I would favor the rmsd package because biopython is quite a bloated library and it would add a big dependency.

@universvm
Copy link

I'd agree with steering away from biopython.

I'll look into it but not sure when I'll have an ETA. Nevertheless I might contact you again about code style etc...

:)

@rasbt
Copy link
Member Author

rasbt commented May 13, 2022

No pressure. This is a hobby project, so whenever you have time and feel like it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants