Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LabProtocol element protocolAdvantage description not clear in combination with property #440

Closed
jjkoehorst opened this issue Aug 14, 2020 · 10 comments

Comments

@jjkoehorst
Copy link

The property protocolAdvantage would suggest that this protocol has some advantage over another protocol and would refer to that. The description however suggests the following:

Situations where the Protocol has been successfully employed (see more information here)

This to me does not fit the name of the property perhaps protocolSuccess could fit the description better or the description could be something like Protocols to which this protocol has an advantage (e.g. better yield, shorter running time)

@ljgarcia
Copy link
Contributor

@jjkoehorst what about keeping the protocolAdvantage property name but changing the description to "Situations where the Protocol has been successfully employed including advantageous elements (e.g. better yield, shorter running time)"
What do you think?

@AlasdairGray
Copy link
Member

I wonder how this property helps satisfy the search or summarisation use cases defined. It seems a very specific property.

@alaninmcr
Copy link
Collaborator

Trying to list the "situations where the Protocol has been successfully employed" is not useful (IMO). If the LabProtocol is used again, is it expected that the field will somehow be updated?

For use of the LabProtocol, it is equally (or more) important to know where the LabProtocol does not work.

@oxgiraldo
Copy link
Contributor

@jjkoehorst, thanks for your comment. The definition should be improve. What do you think about the following definition "Situations where the Protocol has advantageous elements compared to other alternatives (e.g. better yield, shorter running time, greater number of samples tested at the same time, etc.)". Thanks @jjkoehorst and @ljgarcia for the suggestions.

@oxgiraldo
Copy link
Contributor

@AlasdairGray, the property 'protocolAdvantage' is a recommended requirement not a minimum or obligatory requirement. In other words, where applicable, this information should be included.

@ljgarcia
Copy link
Contributor

@alaninmcr, regarding your comment on "equally (or more) important to know where the LabProtocol does not work", there is a property protocolLimitations described as "Situations where the Protocol would be unreliable or otherwise unsuccessful" I think it covers the cases were the protocol does not work, does not it?

@AlasdairGray
Copy link
Member

@AlasdairGray, the property 'protocolAdvantage' is a recommended requirement not a minimum or obligatory requirement. In other words, where applicable, this information should be included.

That doesn't address my question of how this helps with search for a protocol.

@ljgarcia
Copy link
Contributor

@AlasdairGray A user might be interested in protocols known as being successful or having advantages regarding x or y or z. Having a protocolAdvantage makes this search easier.

@oxgiraldo
Copy link
Contributor

@AlasdairGray, to filter a search, the user may be looking for a DNA isolation protocol. as filters then the user could further specify that he/she is interested in a protocol suitable for processing both plants and animals tissues. Or, the user may also simply specify that he/she is interested in only DNA isolation protocols for animals tissues and shorter running time.

@gtsueng
Copy link
Contributor

gtsueng commented Dec 19, 2022

This appears to have been addressed by BioSchemas/bioschemas.github.io#320. Unless @oxgiraldo suggests otherwise, it will be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants