Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View: Tracer is off #166

Open
hmoenck opened this issue May 29, 2018 · 2 comments
Open

View: Tracer is off #166

hmoenck opened this issue May 29, 2018 · 2 comments
Assignees

Comments

@hmoenck
Copy link
Contributor

hmoenck commented May 29, 2018

The tracer does not point exactly to the center of the tracking dot (or vice versa), but instead at the bottom right corner. This is particularly bad, because the trajectory id is rendered there as well and is black as well.

@walachey
Copy link
Member

Please verify that it is not the tracking dot that is off.

@hmoenck
Copy link
Contributor Author

hmoenck commented May 29, 2018

I'm not 100% sure, but I think it is the tracer that is off. This is the line that sets the marker position:
https://github.com/BioroboticsLab/biotracker_core/blob/master/BioTracker/CoreApp/BioTracker/View/ComponentShape.cpp#L268
while this sets the tracer position:
https://github.com/BioroboticsLab/biotracker_core/blob/master/BioTracker/CoreApp/BioTracker/View/ComponentShape.cpp#L349
L268: getXpx() is the member that directly grabs the coordinates from the data structure. Hence getXpx() - m_w/2, where m_w is the width of the marker, should be correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants