Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server - Add 2 DFI as reserved value #833

Closed
4 tasks
thedoublejay opened this issue Mar 27, 2023 · 3 comments · Fixed by #840, #841 or #843
Closed
4 tasks

Server - Add 2 DFI as reserved value #833

thedoublejay opened this issue Mar 27, 2023 · 3 comments · Fixed by #840, #841 or #843
Labels
kind/feature New feature request needs/area Needs area label(s) needs/priority Needs a priority label needs/triage Waiting for triage to be accepted

Comments

@thedoublejay
Copy link
Contributor

thedoublejay commented Mar 27, 2023

What would you like to be added:

We need to have a validation on EVM => DFC flow that there must be 2 DFI always. This is to ensure that we will have enough funds to do other transactions.

  • Add this reserved amount on .env
  • Update "/balances" to deduct RESERVED_AMOUNT (only on DeFiChain side)
  • All consumers of this endpoint should reflect the balance without RESERVED_AMOUNT
  • When sending DFI on EVM => DFC tx, don't include the RESERVED_AMOUNT to prevent emptying out of the HW balance
@thedoublejay thedoublejay added the kind/feature New feature request label Mar 27, 2023
@github-actions github-actions bot added the needs/triage Waiting for triage to be accepted label Mar 27, 2023
@github-actions
Copy link

@thedoublejay: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the BirthdayResearch developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions github-actions bot added the needs/area Needs area label(s) label Mar 27, 2023
@github-actions
Copy link

@thedoublejay: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this!

You can add area labels by leaving a /area comment.

Details

I am a bot created to help the BirthdayResearch developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

@thedoublejay: Thanks for opening an issue, an appropriate priority will be added soon.

The priority labels can be added by foundation members by writing /priority [type] in a comment.

Details

I am a bot created to help the BirthdayResearch developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request needs/area Needs area label(s) needs/priority Needs a priority label needs/triage Waiting for triage to be accepted
Projects
None yet
3 participants