Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit while socks5 proxy alive causes panic #1290

Open
ghost-ng opened this issue Jun 12, 2023 · 0 comments
Open

Exit while socks5 proxy alive causes panic #1290

ghost-ng opened this issue Jun 12, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@ghost-ng
Copy link

Describe the bug
Sometimes, the program will crash if you kill a session that has an active socks5 proxy working

To Reproduce
Get session
Start socks5
exit (not close)

Expected behavior
Stop the socks proxy, exit the program

./sliver-server_linux version
v1.5.39 - af46878

[!] Active session disconnected

[server] sliver > 
[server] sliver > exipanic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0xb8 pc=0xf51776]

goroutine 2753 [running]:
github.com/bishopfox/sliver/server/rpc.(*Server).SocksProxy.func2()
	github.com/bishopfox/sliver/server/rpc/rpc-socks.go:139 +0x76
created by github.com/bishopfox/sliver/server/rpc.(*Server).SocksProxy
	github.com/bishopfox/sliver/server/rpc/rpc-socks.go:131 +0x45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants