Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add total account value to summary page #240

Open
Evanito opened this issue Feb 24, 2017 · 8 comments · May be fixed by #246
Open

Add total account value to summary page #240

Evanito opened this issue Feb 24, 2017 · 8 comments · May be fixed by #246
Assignees
@rnevet
Labels
Enhancement Testing Phase

Comments

@Evanito
Copy link
Member

Evanito commented Feb 24, 2017 •
edited
Loading

It is already listed on Poloniex, but should not be difficult to add to the summary page.
@rnevet
Copy link
Collaborator

rnevet commented Feb 24, 2017 •
edited
Loading

  1. it's not really "lending" bot specific
  2. need to call 'returnCompleteBalances' and calculate the total

@laxdog
Copy link
Collaborator

laxdog commented Feb 25, 2017

Yea, this would be handy. I still log into polo for that. It would be especially handy for me as we could apply output currency to it.

@rnevet
Copy link
Collaborator

rnevet commented Feb 25, 2017

Started working on this.

@rnevet rnevet self-assigned this Feb 25, 2017
@rnevet
Copy link
Collaborator

rnevet commented Feb 26, 2017

I have an implementation working on this branch https://github.com/Mikadily/poloniexlendingbot/tree/total_account_value

Do you think we need to enable/disable the option in the configuration? default to disabled?

@Evanito Evanito removed the Reviewed label Feb 27, 2017
@Evanito
Copy link
Member Author

Evanito commented Feb 27, 2017

Should always be enabled, but (maybe) have a setting between all wallets or just lending.

@rnevet
Copy link
Collaborator

rnevet commented Feb 27, 2017

It seems the api either returns all or exchange, no option to retrieve lending alone.

@Evanito
Copy link
Member Author

Evanito commented Feb 27, 2017

@rnevet https://github.com/Mikadily/poloniexlendingbot/blob/master/modules/Data.py#L129

@rnevet
Copy link
Collaborator

rnevet commented Feb 27, 2017

Those are available balances, not taking offers, active loans. We might have an internal value calculated of the total.

@rnevet rnevet linked a pull request Feb 28, 2017 that will close this issue
Open
9 tasks
@rnevet rnevet mentioned this issue May 22, 2017
Merged
6 tasks
@ghost ghost assigned Evanito Jun 2, 2017
@ghost ghost added Testing Phase and removed In Progress labels Jun 2, 2017
@Evanito Evanito removed their assignment Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rnevet rnevet

Labels
Enhancement Testing Phase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Display Total Account Value BitBotFactory/MikaLendingBot
3 participants
@laxdog @rnevet @Evanito