Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make install installs Google test libs but not NativeJIT #63

Open
joto opened this issue Sep 21, 2016 · 1 comment
Open

make install installs Google test libs but not NativeJIT #63

joto opened this issue Sep 21, 2016 · 1 comment

Comments

@joto
Copy link

joto commented Sep 21, 2016

make install installs gtest and gmock libs and includes, which should probably not be installed, but it doesn't install NativeJIT and CodeGen libs and includes.

@danluu
Copy link
Contributor

danluu commented Sep 22, 2016

Good catch! We obviously don't include NativeJIT this way so the it just happens to do this by coincidence since we weren't thinking about this when we put together the CMakeLists.txt.

If no one else knows the right way to do this, we'll take a look at fixing up our CMakeLists to do the right thing. Sorry about this! We're relatively new to using cmake.

Note to self: we may want to do something like glfw/glfw#30. Or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants