Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support derivation path m/44'/145'/0' for Bitcoin Cash #507

Open
m4ktub opened this issue Feb 17, 2019 · 4 comments
Open

Support derivation path m/44'/145'/0' for Bitcoin Cash #507

m4ktub opened this issue Feb 17, 2019 · 4 comments

Comments

@m4ktub
Copy link

m4ktub commented Feb 17, 2019

I understand why Bitcoin.com wallet uses the BTC derivation path (m/44'/0'/0'). It made for an easy transition for people holding BTC before the fork and, when importing, makes it easier to scan both BTC and BCH network for funds.

That being said the wallet does not support importing a seed with the m/44'/145'/0' derivation path (error message saying derivation path is invalid). This means you can't, for example, import the seed used in Badger Wallet and get the same balance. With Bitcoin.com being one of the most popular wallets, this makes the remaining ecosystem having to decide between standardness and compatibility/user experience.

Please consider creating new Bitcoin Cash wallets with the m/44'/145'/0' derivation while still supporting the BTC derivation path for importing of backups and in the advanced creation of new wallets.

Related issue: #68.

@Bitkilo
Copy link

Bitkilo commented Feb 18, 2019

Thanks for the feedback.
I will pass the idea on

@UnstoppableCash
Copy link

UnstoppableCash commented Feb 20, 2019

That being said the wallet does not support importing a seed with the m/44'/145'/0' derivation path (error message saying derivation path is invalid). This means you can't, for example, import the seed used in Badger Wallet and get the same balance. With Bitcoin.com being one of the most popular wallets, this makes the remaining ecosystem having to decide between standardness and compatibility/user experience.

Please consider creating new Bitcoin Cash wallets with the m/44'/145'/0' derivation while still supporting the BTC derivation path for importing of backups and in the advanced creation of new wallets.

When creating a new (BCH) wallet (WinPC ver:5.4-rc4) using "specify recovery phrase", the field "Derivation Path" is listed and pre-filled out with "m/44'/0'/0'". If I change it to m/44'/145'/0' (Badger/BIP44) I also get a "Error: invalid derivation path". Does this "derivation path" field/option support anything other than "m/44'/0'/0'"? If not, why is it not fixed/constant (just reporting what is supported)? Seems confusing allowing path field to be modified if no other path (at least Bip44) is supported (BCH).

(My steps: New personal wallet->name wallet->show advanced options->wallet key->specify recovery phrase->Derivation Path->m/44'/145'/0'->create wallet->"Error Invalid derivation path")

In any case, the Bitcoin.com wallet really needs to add support for Badger(Bip44 for BCH) since part of the same eco-system. Once Bip44 is supported, maybe new wallets should default to BIP44 so they are compatible with Badger as well. Simplify UX! Badger is just in the early days of mass use, hopefully this compatibility glitch is resolved soon!

TIA!

EDIT: added that issue (lack of Bip44 support) is specific to BCH (not BTC). h/t: m4ktub

@m4ktub m4ktub closed this as completed Feb 20, 2019
@m4ktub
Copy link
Author

m4ktub commented Feb 20, 2019

Sorry, fat finger on mobile. Reopening.

@m4ktub m4ktub reopened this Feb 20, 2019
@lubokkanev
Copy link

When creating a new (BCH) wallet (WinPC ver:5.4-rc4) using "specify recovery phrase", the field "Derivation Path" is listed and pre-filled out with "m/44'/0'/0'". If I change it to m/44'/145'/0' (Badger/BIP44) I also get a "Error: invalid derivation path". Does this "derivation path" field/option support anything other than "m/44'/0'/0'"? If not, why is it not fixed/constant (just reporting what is supported)?

Supported paths seem to be m/(44 or 45 or 48)'/(0 or 1)'/(any)'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@m4ktub @lubokkanev @UnstoppableCash @Bitkilo and others