New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Oracle #142

Open

octgsoftware opened this issue Nov 29, 2022 · 1 comment · Fixed by #177

Labels

Contributor

octgsoftware commented Nov 29, 2022 •

edited

Loading

This should only require writing proper native SQL files for 3 queries and a SqlJdlTypeService.

octgsoftware mentioned this issue

InformationSchema and KeyColumnUsage not generate on Oracle DB. #52

Closed

Blackdread added the enhancement label

mhmmdd mentioned this issue

Oracle Support Implementation #177

Merged

Blackdread closed this as completed in #177

Owner

Blackdread commented Feb 26, 2023

Re-opening this ticket, I think there is still work to be done.
See comment of first PR #177 (comment)

I think, some steps needed:

remove logic if (value.equals("NUMBER(38)") || value.equals("NUMBER(19,5)")) from public static String parseSqlType(String value) of SqlUtils -> Define overridden method in OracleJdlTypeService for default JdlFieldEnum sqlTypeToJdlType(final String sqlType) -> so we can handle oracle specific types and parsing differentely
handle more types
allow definition of short, int, long
better handling of decimal(p, s) -> NUMBER [ (p [, s]) ]

Docs:

Blackdread reopened this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment