Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5844 fixing the background image when minimizing the window #5

Open
bitty7 opened this issue Nov 7, 2019 · 0 comments
Open

#5844 fixing the background image when minimizing the window #5

bitty7 opened this issue Nov 7, 2019 · 0 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@bitty7
Copy link
Collaborator

bitty7 commented Nov 7, 2019

Description

line to the issue: brave#5844

Steps to Reproduce

1- open a new tab
2- minimize the window til the scroll for the height shows up
3- scroll all the way down to find the background image cropped.

Fix:

  1. the path of the file that contains the issue: path:brave_new_tab_/components/default/page/index.ts

  2. Change the position inside the variable PosterBackground to "fixed", and change the "bottom" to value of a positive number

Finding the right file is the step that took most of the time because this project has so many files.

Picture:
3_fixed

Not perfect, but good enough

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@bitty7 bitty7 self-assigned this Nov 7, 2019
@bitty7 bitty7 changed the title #5844 #5844 fixing the background image when minimizing the window Nov 21, 2019
@bitty7 bitty7 added bug Something isn't working enhancement New feature or request good first issue Good for newcomers labels Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant