Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some validation logic for subquery providers #208

Closed
beikov opened this issue Jul 4, 2016 · 1 comment
Closed

Add some validation logic for subquery providers #208

beikov opened this issue Jul 4, 2016 · 1 comment
Assignees
@beikov
Labels
kind: enhancement
Milestone
1.2.0

Comments

@beikov
Copy link
Member

beikov commented Jul 4, 2016

Today we had an issue that a subquery provider was declared as inner (instance) class and that it failed to construct because of the missing outer object argument. We should add some validation logic for subquery providers that catch this case.
@beikov beikov added this to the 1.2.0 milestone Aug 2, 2016
@beikov beikov self-assigned this Aug 2, 2016
@beikov
Copy link
Member Author

beikov commented Sep 10, 2016

Fixed in master

@beikov beikov closed this as completed Sep 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beikov beikov

Labels
kind: enhancement
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
1 participant
@beikov