Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP2 Installer with interactive dialog in a batch instalation #35

Open
3dgiordano opened this issue Oct 17, 2022 · 1 comment
Open
Labels
bug Something isn't working

Comments

@3dgiordano
Copy link
Contributor

3dgiordano commented Oct 17, 2022

When the plugin is installed through the command line and not interactively, the plugin installer displays warning messages with the error.

These alert messages prevent the correct installation of the plugin in a batch mode.
The http2 plugin installer must identify if it is in interactive GUI mode or in non-GUI batch mode, and based on which it should display to the user the error or log to the console or jmeter.log.

The two lines that need that logic

JOptionPane.showMessageDialog(null, "Read or Write permissions denied",

Note:
The easy way to reproduce the problems is with java and the plugin manager using the following command
java -jar ".\jmeter\lib\cmdrunner-2.2.jar" --tool org.jmeterplugins.repository.PluginManagerCMD install bzm-http2

@3dgiordano 3dgiordano added the bug Something isn't working label Oct 17, 2022
@3dgiordano
Copy link
Contributor Author

Analyzing more deeply the problem, I discovered when the plugin is installed on Linux o Mac, the .sh used by plugin manager, force to use the headless mode on awt, that mode, suppress all messages to the user and with that does not block the user./
But on Windows OS the plugin manager not enable that mode, and is possible to block the jmeter or taurus execution in the installation moment if run in batch (or taurus).

I propose to undera the fix on the .bat version of the plugin manager to try to handle plugins with interactive messages in a batch mode.

undera/jmeter-plugins-manager#65

In any case, the plugin should take into consideration whether it is in interactive mode or not, and based on that information, leave the evidence of the problems in the jmeter log and not try to display messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant