Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] No overload method for custom heading? #191

Closed
flamecrow opened this issue Jan 23, 2023 · 3 comments · Fixed by #192
Closed

[Bug] No overload method for custom heading? #191

flamecrow opened this issue Jan 23, 2023 · 3 comments · Fixed by #192
Labels
Docs Issue relating to documentation

Comments

@flamecrow
Copy link

flamecrow commented Jan 23, 2023

Describe the bug
README says you can use
toastService.ShowSuccess("I'm a SUCCESS message with a custom title", "Congratulations!"))
However, there is no such overload method that takes two strings like this (breaking change from version 3.2.2).
Second parameter is now looking for
Action<ToastSettings>? settings = null

To Reproduce
Steps to reproduce the behavior:

  1. Create project
  2. Try to pass two strings to toast for "message" and "custom header"

Expected behavior
Allow passing two strings to toast to show message and custom header.

Screenshots
image

Hosting Model (is this issue happening with a certain hosting model?):

  • Blazor Server
  • Blazor WebAssembly
@flamecrow flamecrow added Bug Something isn't working Triage Issue needs to be triaged labels Jan 23, 2023
@chrissainty
Copy link
Member

Good spot, thanks @flamecrow. I missed that when updating the docs. I'll get a PR raised in a sec to update that call and remove the custom title.

@chrissainty chrissainty added Docs Issue relating to documentation and removed Bug Something isn't working Triage Issue needs to be triaged labels Jan 23, 2023
@Skyl3lazer
Copy link

Is it intended that we can no longer customize the toasts like this, or is there another way to do it now? I used this feature extensively.

@chrissainty
Copy link
Member

Custom headings have been removed. There is just the message now. If you want to use a heading as well as a message then you can use the custom component option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs Issue relating to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants