Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Fade Out Functionality #229

Open
creed-maxeta opened this issue Jul 17, 2023 · 1 comment
Open

[Feature] Add Fade Out Functionality #229

creed-maxeta opened this issue Jul 17, 2023 · 1 comment
Labels
Feature New feature that will be added to the project

Comments

@creed-maxeta
Copy link

creed-maxeta commented Jul 17, 2023

I am interested in having toasts fade out, similar to how they fade in. I have tried to a apply a class that has a fade out animation, almost identical to how the fade in animation is applied (see image below), but this did not work. I am not seeing my override class applied to the modal even though I am setting the SuccessClass within the Toast declaration. When applying the class manually within the dev console, I still don't see the functionality.

Potentially related to this closed PR #84

  • Is there any reason this functionality is not included by default?
  • Is there a nice workaround to achieve this functionality without having to apply fully custom styling?

image

@creed-maxeta creed-maxeta added Question Question about this project Triage Issue needs to be triaged labels Jul 17, 2023
@chrissainty
Copy link
Member

@creed-maxeta Fade out functionality is a little trickier than fade in as it's a two stage process, fade the element out using CSS then physically remove the element from the DOM once it's transition is complete.

I can't give you a good reason as to why it isn't in the library. I think it's something that would make sense to add.

@chrissainty chrissainty added Feature New feature that will be added to the project and removed Question Question about this project Triage Issue needs to be triaged labels Jul 23, 2023
@chrissainty chrissainty changed the title [Question] Fade Out Functionality [Feature] Add Fade Out Functionality Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature that will be added to the project
Projects
None yet
Development

No branches or pull requests

2 participants