Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling is cancelled when a RPG Maker MZ game reloads #508

Closed
necaran opened this issue Mar 25, 2023 · 5 comments
Closed

Scaling is cancelled when a RPG Maker MZ game reloads #508

necaran opened this issue Mar 25, 2023 · 5 comments
Labels
bug Something isn't working priority: normal

Comments

@necaran
Copy link

necaran commented Mar 25, 2023

Magpie version 程序版本

v0.10.0

Windows version 系统版本

win10

Related screenshot (optional) 相关截图(可选)

No response

Reproduction steps 复现步骤

  1. Run a RPG Maker MZ game
  2. Start scaling with Magpie
  3. Reload the game by pressing F5

The reason for this behavior is that the class name of the window changes when the game reloads. When the game first launched the class is Chrome_WidgetWin_1 and if reloaded it became Chrome_WidgetWin_2. The number increases with every reload. Because of this behavior, it would also fail to apply the profile for a RPG Maker MZ game after reload because classNameRule does not match.

Log files 日志文件

@necaran necaran added the bug Something isn't working label Mar 25, 2023
@eriforce
Copy link
Contributor

eriforce commented Mar 26, 2023

maybe a toggle could be added to disable/ignore classNameRule matching for a profile or an application?

@Blinue
Copy link
Owner

Blinue commented Mar 26, 2023

I'm investigating the issue.

@Blinue Blinue added this to Magpie Mar 28, 2023
@Blinue Blinue moved this to Todo in Magpie Mar 28, 2023
@Blinue
Copy link
Owner

Blinue commented Mar 28, 2023

@rn83 You are correct. I have to handle these windows specially, just like WPF windows.

@eriforce I don't think it's a good idea because most users don't even know what window classes are.

@Blinue Blinue moved this from Todo to In Progress in Magpie Mar 28, 2023
@eriforce
Copy link
Contributor

eriforce commented Mar 28, 2023

@eriforce I don't think it's a good idea because most users don't even know what window classes are.

I mean it could something like "match with path only", not necessary to mention class, just my random idea.

I'm also curious about the reason class name is taken into consideration, is it for processes with multiple windows?

@Blinue
Copy link
Owner

Blinue commented Mar 28, 2023

I mean it could something like "match with path only", not necessary to mention class, just my random idea.

That's true. However, we already have the logic to handle WPF windows, so it would be easier to extend it based on that.

I'm also curious about the reason class name is taken into consideration, is it for processes with multiple windows?

This is a carefully considered decision.

  • It can avoid scaling pop-ups.
  • The profiles are for windows rather than processes. If a process has multiple windows of different types, it is not appropriate for them to share the same profile.
  • In most cases, the class name of a window remains unchanged, except for some very special cases like RPG Maker MZ.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: normal
Projects
Archived in project
Development

No branches or pull requests

3 participants