Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aliasing in magpie. #74

Closed
dasanibroto opened this issue Aug 19, 2021 · 15 comments
Closed

Aliasing in magpie. #74

dasanibroto opened this issue Aug 19, 2021 · 15 comments
Labels
enhancement New feature or request

Comments

@dasanibroto
Copy link

I am wondering if magpie will ever include some sort of anti aliasing pass? FSR can really exaggerate aliasing, so it'd be very nice to see.

@Apprisco
Copy link

FSR is just CAS + Upscaling, AA is supposed to be enabled by the application.
For most programs, you can add antialiasing by using NVIDIA control panel and adding them in 3d settings - program settings.

@dasanibroto
Copy link
Author

Obviously I understand that, but enabling aa in the game is doing the aa pass on the 1080p image, then after if gets upscaled new aliasing artifacts appear. What I want is an aa pass on the full 4k image.

@Blinue Blinue added the enhancement New feature or request label Aug 21, 2021
@Blinue
Copy link
Owner

Blinue commented Aug 21, 2021

The choice of anti-aliasing algorithms is limited as Magpie can only post-process the image. The most ideal algorithm I could find is FXAA, and I will port it in the future.

@dasanibroto
Copy link
Author

Could you also please consider smaa, since that is the method people most commonly use on reshade.

@Blinue
Copy link
Owner

Blinue commented Aug 21, 2021

I will port them both in v0.7 :)

@Apprisco
Copy link

Is TAA post processing? Unsure, but it'd be a nice option to have <3

@Blinue
Copy link
Owner

Blinue commented Aug 22, 2021

TAA should be implemented at the driver or engine level, not at the post-processing stage.

@Blinue Blinue mentioned this issue Aug 29, 2021
19 tasks
@Blinue
Copy link
Owner

Blinue commented Nov 2, 2021

I've ported FXAA and SMAA. Use with caution, they are expensive and don't work as well as native anti-aliasing.

@Blinue Blinue closed this as completed Nov 15, 2021
@Apprisco
Copy link

How do we actually use the ported FXAA and SMAA? is it in the scale config?

@Blinue
Copy link
Owner

Blinue commented Nov 21, 2021

Add this to your ScaleModels.json

{
  "name": "FSR+FXAA",
  "effects": [
    {
      "effect": "FSR_EASU",
      "scale": [ -1, -1 ]
    },
    {
      "effect": "FSR_RCAS",
      "sharpness": 0.87
    },
    {
      "effect": "FXAA_Medium"
    }
  ]
},
{
  "name": "FXAA+FSR",
  "effects": [
    {
      "effect": "FXAA_Medium"
    },
    {
      "effect": "FSR_EASU",
      "scale": [ -1, -1 ]
    },
    {
      "effect": "FSR_RCAS",
      "sharpness": 0.87
    }
  ]
}

@petsild
Copy link

petsild commented Nov 22, 2021

How do I please activate the SMAA at FSR, thank you very much. Pet

@JohnnyJosda
Copy link

这两种写法除了顺序不同,有什么区别吗

@Blinue
Copy link
Owner

Blinue commented Apr 13, 2023

这两种写法除了顺序不同,有什么区别吗

先抗锯齿然后缩放更快,哪个效果更好见仁见智。

@JohnnyJosda
Copy link

这两种写法除了顺序不同,有什么区别吗

先抗锯齿然后缩放更快,哪个效果更好见仁见智。

这么说,先锯齿画面会更好?
还有个问题,这种改变执行顺序的写法我应该如何在高版本(图形化)实现?

@Blinue
Copy link
Owner

Blinue commented Apr 13, 2023

按顺序添加效果即可

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants