Merge #281: Make *key_cache const in musig_pubkey_get

jonasnick · jonasnick · commit 0ffca6f79468 · 2024-01-08T08:03:41.000Z
e2eb3fa Make *key_cache const in musig_pubkey_get (Sanket Kanjalkar) Pull request description: ACKs for top commit: jonasnick: ACK e2eb3fa Tree-SHA512: 24d1375bd48440e805e82d8a7d371eebfa98f7ef2c7a60d86c720e8512b5fa5bb70499ea821f9cef81c73145a3569c243fa0ecb1c29d7c31c4515dafeba80e23
diff --git a/include/secp256k1_musig.h b/include/secp256k1_musig.h
@@ -234,7 +234,7 @@ SECP256K1_API int secp256k1_musig_pubkey_agg(
 SECP256K1_API SECP256K1_WARN_UNUSED_RESULT int secp256k1_musig_pubkey_get(
     const secp256k1_context *ctx,
     secp256k1_pubkey *agg_pk,
-    secp256k1_musig_keyagg_cache *keyagg_cache
+    const secp256k1_musig_keyagg_cache *keyagg_cache
 ) SECP256K1_ARG_NONNULL(1) SECP256K1_ARG_NONNULL(2) SECP256K1_ARG_NONNULL(3);
 
 /** Apply plain "EC" tweaking to a public key in a given keyagg_cache by
diff --git a/src/modules/musig/keyagg_impl.h b/src/modules/musig/keyagg_impl.h
@@ -278,7 +278,7 @@ int secp256k1_musig_pubkey_agg(const secp256k1_context* ctx, secp256k1_scratch_s
     return 1;
 }
 
-int secp256k1_musig_pubkey_get(const secp256k1_context* ctx, secp256k1_pubkey *agg_pk, secp256k1_musig_keyagg_cache *keyagg_cache) {
+int secp256k1_musig_pubkey_get(const secp256k1_context* ctx, secp256k1_pubkey *agg_pk, const secp256k1_musig_keyagg_cache *keyagg_cache) {
     secp256k1_keyagg_cache_internal cache_i;
     VERIFY_CHECK(ctx != NULL);
     ARG_CHECK(agg_pk != NULL);

Original file line number	Diff line number	Diff line change
`@@ -278,7 +278,7 @@ int secp256k1_musig_pubkey_agg(const secp256k1_context* ctx, secp256k1_scratch_s`
`278`	`278`	`return 1;`
`279`	`279`	`}`
`280`	`280`
`281`		`-int secp256k1_musig_pubkey_get(const secp256k1_context* ctx, secp256k1_pubkey agg_pk, secp256k1_musig_keyagg_cache keyagg_cache) {`
	`281`	`+int secp256k1_musig_pubkey_get(const secp256k1_context* ctx, secp256k1_pubkey agg_pk, const secp256k1_musig_keyagg_cache keyagg_cache) {`
`282`	`282`	`secp256k1_keyagg_cache_internal cache_i;`
`283`	`283`	`VERIFY_CHECK(ctx != NULL);`
`284`	`284`	`ARG_CHECK(agg_pk != NULL);`