-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dependabot to update all mods daily #2
Comments
I like to do at least some superficial testing of mods before pulling in updates. I suppose if I could set up that github thing that automatically boots a server I could automate some tests, but that's not likely to happen soon. What mods in particular need an update? |
For example: EDIT: Maybe adding |
The bot submits a PR, and choose whether to merge it or not. |
dependabot preview is currently the oldest still supported version, you should really be using version two. to enable this go to |
As the person now responsible for updating mods I do not like the idea of this - there should be the potential of a review process and the ability to stay at a version if we choose. Although this would be helpful, it would also be dangerous - even when only considering the updates we make ourselves. The danger outweighs any benefit in my opinion. |
"there should be the potential of a review process and the ability to stay at a version if we choose." All it does is submit a pr if your submodule gets a update, you can review, close the pr, etc, i fail to see how this doesnt allow or a review, or is dangerous, given that literally anyone can make a pr |
@wsor4035 because as soon as you choose to stay behind a version on one of the modules the PRs become useless and actually may become a nuisance. It allows for the chance that someone accepts a PR with a breaking change because every other update in the list is good. |
"because as soon as you choose to stay behind a version on one of the modules the PRs become useless and actually may become a nuisance." this is wrong, it makes individual PR's for each submodule update, and you can just close the one you dont want to update further. doing so does not affect the others at all. "It allows for the chance that someone accepts a PR with a breaking change because every other update in the list is good." |
Should this be closed or? |
Currently, many mods are (very) outdated.
Only if mods are not modified, otherwise, AFAIK, existing changes will be overwritten.
Link to the app: https://github.com/marketplace/dependabot-preview
The text was updated successfully, but these errors were encountered: