Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frame little/big endian overhauling in frames #246

Open
FrancescAlted opened this issue Feb 19, 2021 · 1 comment
Open

Frame little/big endian overhauling in frames #246

FrancescAlted opened this issue Feb 19, 2021 · 1 comment

Comments

@FrancescAlted
Copy link
Member

Frame serialization needs an overhauling so as to make sure that:

  1. All ints for msgpack are to be stored in big-endian (aka network-endian)

  2. The rest of ints (e.g. offsets of chunks in frames) are to be stored in little-endian

So yeah, we have a nice mix of big and little endian embedded in the frame serialization format. The reason for this apparent schizophrenia is that msgpack is strict about using big-endian, and Blosc has historically used little-endian for serializing the ints in the chunk header (which makes sense provided the prevalence of little-endian CPUs nowadays).

We will setup some macros that should make this big/little endian handling easier.

@aleixalcacer
Copy link
Member

the macros wil be introduced in #247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants