Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chunksize == 0 #367

Open
DimitriPapadopoulos opened this issue Dec 1, 2021 · 0 comments
Open

chunksize == 0 #367

DimitriPapadopoulos opened this issue Dec 1, 2021 · 0 comments

Comments

@DimitriPapadopoulos
Copy link
Contributor

Describe the bug

I'm puzzled by chunksize == 0 in this piece of code:

c-blosc2/blosc/frame.c

Lines 2424 to 2426 in b2434ad

// Check that we are not appending a small chunk after another small chunk
int32_t chunk_nbytes_last;
if (chunksize == 0 && (nchunks > 0) && (chunk_nbytes < (size_t)chunksize)) {

  • if chunksize == 0, then chunk_nbytes < (size_t)chunksize) is equivalent to chunk_nbytes < 0)
  • chunksize == 0 does not seem consistent with the Check that we are not appending a small chunk after another small chunk comment, but I may be wrong here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant