-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake issue with v2.2.2 #394
Comments
See #257 for my earlier, but yet rejected, initiative |
Thanks @tdegeus. Beyond your (very welcome) modernization of Highfive's cmake, it seems that there is a legitimate bug here. Highfive's cmake should probably install the libdeps target. |
Concerning CMake one additional note: Now HighFive tries to find HDF5 with command On windows it is always difficult to find hdf5 this way: all libraries compiled by me not added to any env::var. So I propose to use |
It seems this error is still there with Hifive v2.3.1. We are still pinning on v2.1 because of it...
|
We've rewritten the HighFive CMake related code for |
When updating
highfive
from v2.1.1 to v2.2.2 in xtensor-io in xtensor-stack/xtensor-io#124, we get the following error (see the logs):A work-around was to add libdeps to xtensor-io's target, but is there a way to fix it upstream?
The text was updated successfully, but these errors were encountered: