Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake issue with v2.2.2 #394

Closed
davidbrochart opened this issue Dec 10, 2020 · 5 comments
Closed

cmake issue with v2.2.2 #394

davidbrochart opened this issue Dec 10, 2020 · 5 comments
Assignees
Labels
cmake Anything build-system (CMake) related.

Comments

@davidbrochart
Copy link

When updating highfive from v2.1.1 to v2.2.2 in xtensor-io in xtensor-stack/xtensor-io#124, we get the following error (see the logs):

CMake Error: install(EXPORT "xtensor-io-targets" ...) includes target "xtensor-io" which requires target "libdeps" that is not in any export set.

A work-around was to add libdeps to xtensor-io's target, but is there a way to fix it upstream?

@tdegeus
Copy link
Collaborator

tdegeus commented Dec 12, 2020

See #257 for my earlier, but yet rejected, initiative

@SylvainCorlay
Copy link

Thanks @tdegeus. Beyond your (very welcome) modernization of Highfive's cmake, it seems that there is a legitimate bug here.

Highfive's cmake should probably install the libdeps target.

@kerim371
Copy link
Contributor

Concerning CMake one additional note:

Now HighFive tries to find HDF5 with command find_package(HDF5 REQUIRED) which (as far as I know) involves CMake module to find HDF5.

On windows it is always difficult to find hdf5 this way: all libraries compiled by me not added to any env::var.
When I try to configure HighFive with CMake GUI and after I manually set all path to hdf5 I get error as shown in the picture.

So I propose to use find_package(HDF5 REQUIRED CONFIG) and that would allow to simply set HDF5_DIR to hdf5-config.cmake and HDF5 is found.

image

@pramodk pramodk added the cmake Anything build-system (CMake) related. label Mar 3, 2021
@SylvainCorlay
Copy link

It seems this error is still there with Hifive v2.3.1. We are still pinning on v2.1 because of it...

CMake Error in CMakeLists.txt:
  export called with target "xtensor-io" which requires target "libdeps" that
  is not in any export set.

@1uc
Copy link
Collaborator

1uc commented Feb 13, 2024

We've rewritten the HighFive CMake related code for v3 and are close to of have merge the changes. I'm closing this issue as outdated. Please open a new Issue if the problem persists after #897 got merged.

@1uc 1uc closed this as completed Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmake Anything build-system (CMake) related.
Projects
None yet
Development

No branches or pull requests

7 participants