Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.16.5-1.6.12] Coralstone Replacement configuredfeature cannot be turned into json. #12

Open
TelepathicGrunt opened this issue Oct 1, 2021 · 0 comments

Comments

@TelepathicGrunt
Copy link

TelepathicGrunt commented Oct 1, 2021

When using Jellyfishing with Blame on, Blame reports in the log that the Corrock Tower configuredfeature is unabled to be turned back into json (typically for mod compat). https://paste.ee/p/V7G6h

The issue is the 250 for count method is too large for the count codec which is limited to -10 to 128. Instead, a simple solution is to swap func_242731_b(250) with withPlacement(Placement.COUNT_EXTRA.configure(new AtSurfaceWithExtraConfig(256, 0F, 0))) since the count extra placement does not have any limit. Also, the 100 for the OreFeatureConfig is too large as the max is 64 for it. In fact, 100 is a bit of overkill as remember, features only get a 3x3 chunk area they can spawn in. So at 100 size, the feature will pretty much always be cut off at chunk edges for the 3x3 chunk area. Perhaps lowering it to 64 and bumping up the count slightly will be better?

public static final ConfiguredFeature<?, ?> CONFIGURED_CORALSTONE_REPLACEMENT = Feature.ORE.withConfiguration(new OreFeatureConfig(OreFeatureConfig.FillerBlockType.BASE_STONE_OVERWORLD, JellyfishingBlocks.CORALSTONE.get().getDefaultState(), 100)).range(300).square().func_242731_b(250);

Hope this helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant