Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ImportH5 [Oim|Esprit|OINA] Data Filters to allow importing scans as separate geometries #510

Open
3 tasks done
jmarquisbq opened this issue Mar 24, 2023 · 2 comments · May be fixed by #1130
Open
3 tasks done

Update ImportH5 [Oim|Esprit|OINA] Data Filters to allow importing scans as separate geometries #510

jmarquisbq opened this issue Mar 24, 2023 · 2 comments · May be fixed by #1130
Assignees
@nyoungbq
Labels
enhancement New feature or request Filter Adds a new filter

Comments

@jmarquisbq
Copy link
Contributor

jmarquisbq commented Mar 24, 2023 •
edited by nyoungbq
Loading

Currently all the scans will be stacked and imported as a single geometry. It would be nice to also have the option to instead import them all as separate geometries.

  • Would not use the z spacing or origin inputs and instead get these from the reader
  • May need to use default values for origin & spacing for each geometry in preflight and resize in execute to avoid too much file parsing in preflight (or have some sort of caching mechanism)

TODO:

  • Oim
  • Esprit
  • OINA
@jmarquisbq jmarquisbq added enhancement New feature or request Filter Adds a new filter labels Mar 24, 2023
@imikejackson imikejackson changed the title Update ImportH5[Oim/Esprit]Data Filters to allow importing scans as separate geometrys Update ImportH5[Oim/Esprit]Data Filters to allow importing scans as separate geometries May 14, 2024
@imikejackson imikejackson changed the title Update ImportH5[Oim/Esprit]Data Filters to allow importing scans as separate geometries Update ImportH5 [Oim|Esprit|OINA] Data Filters to allow importing scans as separate geometries May 14, 2024
@imikejackson
Copy link
Contributor

All 3 readers are very similar. The same sets of code should be able to be reused between them.

@nyoungbq
Copy link
Contributor

I will take this issue

@nyoungbq nyoungbq linked a pull request Nov 15, 2024 that will close this issue
Draft
10 tasks
@nyoungbq nyoungbq linked a pull request Nov 15, 2024 that will close this issue
[WIP] ENH: H5 Readers - Allow Separate Scans from Single File #1130
Draft
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nyoungbq nyoungbq

Labels
enhancement New feature or request Filter Adds a new filter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] ENH: H5 Readers - Allow Separate Scans from Single File nyoungbq/simplnx
4 participants
@imikejackson @JDuffeyBQ @jmarquisbq @nyoungbq