Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metaEnvironment does not seem to support var substitution #573

Closed
sixtyfourktec opened this issue Jul 3, 2024 · 2 comments · Fixed by #577
Closed

metaEnvironment does not seem to support var substitution #573

sixtyfourktec opened this issue Jul 3, 2024 · 2 comments · Fixed by #577

Comments

@sixtyfourktec
Copy link

Something like this is not possible right now:

metaEnvironment:
       PKG_VERSION: "$LINUX_VERSION"

If we have generic recipes which e.g. get the version number to be used passed in, it would be nice if this is also reflected in the PKG_VERSION. I guess this would be the main place someone would like to look at for this kind of information.

@rhubert
Copy link
Contributor

rhubert commented Jul 16, 2024

I can't remember why we decided not to substitute this. It's also not mentioned in the PR 🤔 @jkloetzke can you remember?

As I also have this use-case and don't see a good reason against I think this could be supported.

@jkloetzke
Copy link
Member

IIRC we thought that it's not necessary because the meta environment should describe static properties of the recipe/package. Apparently this assumption simply does not hold. So I guess we should just add the substitution support and let it behave like privateEnvironment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants