Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nested levels/use of content include tags #2845

Closed
sid3windr opened this issue Jul 14, 2021 · 7 comments
Closed

Support nested levels/use of content include tags #2845

sid3windr opened this issue Jul 14, 2021 · 7 comments

Comments

@sid3windr
Copy link

Describe the bug
Multiple layers of page inclusion are not being evaluated correctly.

Steps To Reproduce
Steps to reproduce the behavior:

  1. Create page A with some content.
  2. Create page B with some content, and include page A in it. This will display correctly.
  3. Create page C with some content, and include page B in it.
  4. Page C will have the page C content from step 3, and the page B content from step 2, followed by the {{@123}} inclusion tag for page A, instead of page A's content.

Expected behavior
All pages to be included should be displayed correctly.

Your Configuration (please complete the following information):

  • Exact BookStack Version (Found in settings): 21.04
  • PHP Version: 7.3.29
  • Hosting Method (Nginx/Apache/Docker): Apache
@ssddanbrown
Copy link
Member

Related to #1601

@ssddanbrown ssddanbrown changed the title Including a page with another included page does not show all content Support nested levels/use of content include tags Oct 21, 2021
@robertfshort
Copy link

+1 for this feature

@JoeIzzard
Copy link

+1 for this

@jasonF1000
Copy link
Contributor

+1 for this feature

1 similar comment
@deleyva
Copy link

deleyva commented Mar 30, 2023

+1 for this feature

@jasonF1000
Copy link
Contributor

Hi,

i think a depth of 3 layers for the page inclusion should be enoght for the most cases.
Is there any implementation Plan in the near Future for this Feature?

Regards,
jason

@ssddanbrown
Copy link
Member

Up to three levels of nested has now been added within the work of PR #4192, thanks to @jasonF1000.
Will be part of the next feature release.

@ssddanbrown ssddanbrown added this to the Next Feature Release milestone Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

6 participants