Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong pluralization for non-english languages #417

Closed
jonas-koeritz opened this issue Jun 14, 2017 · 2 comments
Closed

Wrong pluralization for non-english languages #417

jonas-koeritz opened this issue Jun 14, 2017 · 2 comments

Comments

@jonas-koeritz
Copy link

For Bug Reports

  • BookStack Version: v0.16.3
  • PHP Version: irrelevant
  • MySQL Version: irrelevant
Expected Behavior

Correct pluralization of terms for non-english languages.

Actual Behavior

The profile view uses str_plural() to pluralize terms. This only works for english nouns. German nouns get pluralized the wrong way.

Proposed fix

Switch to trans_choice() to provide localized pluralizations.

@timoschwarzer
Copy link
Contributor

+1

@ssddanbrown
Copy link
Member

@jonas-koeritz Thanks for creating this issue. View now updated, for v0.18 release, to use trans_choice. Lang files will need to be updated.

Relevant strings can be found under the keys: entities.x_books, entities.x_chapters, entities.x_pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants