Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non PSR-4 compliant test class namespace #5071

Closed
LordSimal opened this issue Jun 17, 2024 · 0 comments · Fixed by #5291
Closed

Non PSR-4 compliant test class namespace #5071

LordSimal opened this issue Jun 17, 2024 · 0 comments · Fixed by #5291
Labels
Milestone

Comments

@LordSimal
Copy link
Contributor

Describe the Bug

After a composer install command it shows the following warnings:

Class Activity\WebhookCallTest located in ./tests/Activity/WebhookCallTest.php does not comply with psr-4 autoloading standard (rule: Tests\ => ./tests). Skipping.
Class Activity\WebhookFormatTesting located in ./tests/Activity/WebhookFormatTesting.php does not comply with psr-4 autoloading standard (rule: Tests\ => ./tests). Skipping.
Class Activity\AuditLogApiTest located in ./tests/Activity/AuditLogApiTest.php does not comply with psr-4 autoloading standard (rule: Tests\ => ./tests). Skipping.
Class Activity\WebhookManagementTest located in ./tests/Activity/WebhookManagementTest.php does not comply with psr-4 autoloading standard (rule: Tests\ => ./tests). Skipping.
Class Activity\AuditLogTest located in ./tests/Activity/AuditLogTest.php does not comply with psr-4 autoloading standard (rule: Tests\ => ./tests). Skipping.

Steps to Reproduce

  1. Download latest Bookstack (24.05.2 as of right now)
  2. perform a composer install with PHP 8.3 and composer 2.7.7

Expected Behaviour

No PSR autoloading warnings on composer install

Screenshots or Additional Context

This can be fixed rather easily by adjusting the namespace of e.g. tests/Activity/WebhookCallTest.php (and all other files from above) from

namespace Activity;

to

namespace Tests\Activity;

since the Tests namesapce is defined in the composer.json

Browser Details

No response

Exact BookStack Version

24.05.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants