Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theme category in settings page #5251

Closed
2 tasks done
LachTrip opened this issue Oct 10, 2024 · 2 comments
Closed
2 tasks done

Add theme category in settings page #5251

LachTrip opened this issue Oct 10, 2024 · 2 comments
Milestone

Comments

@LachTrip
Copy link

Attempted Debugging

  • I have read the debugging page

Searched GitHub Issues

  • I have searched GitHub for the issue.

Describe the Scenario

Trying to make an additional settings page for my bookstack theme. I can add a new category to settings.layout and have a custom settings page, but to be able to access it I need to add an entry to the settingCategories in app/Settings/SettingController.php, which does not seem possible through current theming options.

Exact BookStack Version

v24.03-dev

Log Content

No response

Hosting Environment

Debian docker

@ssddanbrown
Copy link
Member

Hi @LachTrip,
Yeah, the categories are not made customizable in any way.

I guess we could change this up so, instead of validating the categories by fixed array, we could validate them by checking for an existing matching view file. Would probably be best to move the existing setting category layouts into their own view folder though to prevent any pollution in that respect.

@ssddanbrown
Copy link
Member

Now achieved via your PR #5255, thanks again @LachTrip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants