Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API attachment update can result in a Undefined array key "name" error #5353

Closed
ssddanbrown opened this issue Dec 7, 2024 · 0 comments
Closed
Labels
Milestone

Comments

@ssddanbrown
Copy link
Member

Describe the Bug

Performing an API attachment update following the API docs can result in a Undefined array key "name" error.
This is because the name is not required for validation, but assumed to be set in the called service:

$attachment->name = $requestData['name'];

Steps to Reproduce

  1. Perform API attachment update call without a name parameter.
  2. See 500 error

Expected Behaviour

API call succeeds and no error thrown.

Screenshots or Additional Context

No response

Browser Details

No response

Exact BookStack Version

v24.10.3

@ssddanbrown ssddanbrown added this to the v24.12 milestone Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant