-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Empty value for compare limits changes results, silently without error #144
Comments
Those appear to be two different queries? (publication_country__id is in the second). Behavior is anticipated but maybe not explained anywhere. An empty compare_limits should be If compare_limits is undefined and 'word' is not a key in the search_limits, I think it just starts removing things by some pattern I don't fully know. There's also an undocumented shorthand where you can write {"search_limits": {"word": ["foo"], "*topic": ["bar"]}} where the asterisk directs the API to drop topic, rather than 'word', when it builds |
Different results between a normal query:
https://bookworm.htrc.illinois.edu/cgi-bin/dbbindings.py?query={"groups":["date_year"],"counttype":"WordsPerMillion","words_collation":"Case_Insensitive","database":"Bookworm2016","search_limits":{"word":["tea"]},"method":"data","format":"json"}
vs one with "compare_limits":[]:
https://bookworm.htrc.illinois.edu/cgi-bin/dbbindings.py?query={"groups":["date_year"],"counttype":"WordsPerMillion","compare_limits":[],"words_collation":"Case_Insensitive","database":"Bookworm2016","search_limits":{"word":["tea"],"publication_country__id":["2"]},"method":"data","format":"json"}
The text was updated successfully, but these errors were encountered: