Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new tests for Coordinate system #57

Open
6 of 7 tasks
lpranam opened this issue Jul 23, 2019 · 2 comments · May be fixed by #130
Open
6 of 7 tasks

Add new tests for Coordinate system #57

lpranam opened this issue Jul 23, 2019 · 2 comments · May be fixed by #130
Assignees
@lpranam
Labels
test Related to the tests

Comments

@lpranam
Copy link
Member

lpranam commented Jul 23, 2019 •
edited
Loading

Currently, the coordinate system has limited tests which do not cover all the aspects and all cases but only basic tests from constructors and methods.

For geometric coordinate systems:

New tests should at least include separate tests for each geometric class, conversion tests and arithmetic method tests with most of the common combinations of different systems.

Test:

  • cartesian_representation
  • cartesian_differential
  • spherical_representation
  • spherical_differential
  • spherical_coslat_differential
  • spherical_equatorial_representation
  • spherical_equatorial_differential

For astronomical Coordinate systems:

There are no existing tests for any of astronomical coordinate system and will require test development from scratch.
@lpranam lpranam added the test Related to the tests label Jul 23, 2019
@lpranam lpranam self-assigned this Jul 23, 2019
@lpranam lpranam mentioned this issue Aug 4, 2019
Merged
1 task
@Gopal-Dahale
Copy link

I would like to work on this issue. I want to know more about this issue. What type of tests are we looking? I have gone through cartesian_representation.hpp but still confused.

@rjnrohit
Copy link

rjnrohit commented Apr 13, 2020 •
edited
Loading

Hey, @Gopal-Dahale I have done some work on this issue you may wanna see it here in PR #130

@rjnrohit rjnrohit linked a pull request Apr 21, 2020 that will close this issue
Open
@div5252 div5252 mentioned this issue Jan 8, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lpranam lpranam

Labels
test Related to the tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add test for spherical_coslat_differential rjnrohit/astronomy
3 participants
@lpranam @rjnrohit @Gopal-Dahale