-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vim inside motion doesn't work for [, (, {, t, others? (OS X) #1003
Comments
Hi, @prurph. Thanks for opening an issue. What you want in Vim mode is not actually Boostnote's issue because we use CodeMirror as the code editor so you should open an issue on CodeMirror. However, I'll try to manage them because chances are that there're ways, which I don't know, to implement it. If you have it, please let us know. |
Thank you for responding--the reason I opened it here is because it works in the CodeMirror demo. For example, go to demo link, put your cursor on the v in I can try looking at the source to see if it's something the embedding code needs to implement; my hunch was it should work out of the box and something else Boostnote is listening for or doing might be breaking it. |
Oh, I didn't know so I'll review the settings and try to improve. |
Great--thank you for taking a look! Boostnote is really cool. :] |
Just came across this issue myself My environment:
Uploaded two videos to compare between behavior on Boostnote and the correct behavior.
These key sequences (i.e. "Vim text objects") also work on Tampermonkey which uses CodeMirror. UpdateOk saw some error message on the developer console. I pasted it in this gist: https://gist.github.com/i-give-up/f665d1284cfa2ea3c3470c06570db137 It mentioned something about |
I think there's two reasons why this doesn't work. 1. matchbrackets.js is requiredAccording to demo site, If this module is imported in main.html, we can use 2. CodeMirror seems like having a problem with the Vim mode.It seems like Vim mode on CodeMirror can't scan brackets when brackets have styles(like color or underscore etc..) of html. I opened an issue and pull request on CodeMirror repository to ask this issue. |
Expected behavior: typing
ci(
with the cursor in normal mode and inside(foo)
should deletefoo
and leave the cursor in insert mode inside the remaining()
.Actual behavior in Boostnote on OS X: nothing happens and the cursor remains in normal mode.
The same thing happens for other keys like
{
,[
andt
(for tag)These commands work in the Codemirror demo--except for t--just not in Boostnote. It only appears to support
ci"
andci'
.The text was updated successfully, but these errors were encountered: