Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Over-aggressive Autoclosing (back ticks, asterisks, quotes) #2334

Closed
jstobin opened this issue Aug 24, 2018 · 2 comments
Closed

Over-aggressive Autoclosing (back ticks, asterisks, quotes) #2334

jstobin opened this issue Aug 24, 2018 · 2 comments
Labels
improvement request 🔨 Issue concerns an existing feature that needs improvement.

Comments

@jstobin
Copy link

jstobin commented Aug 24, 2018

Current behavior

If trying to create a bulleted list the current behavior always enters two asterisks, when trying to close a code block or edit back ticks it aggressively adds 6 back ticks. I believe other characters are impacted but asterisks and back ticks are two I hit many times daily.

This enhancement may be related:
#1428
screen shot 2018-08-24 at 12 53 21 am

Expected behavior

Smarter detection autoclosing. Not exactly sure how to resolve but some ideas:

  • Detect if closing an open block (quotes seem to behave correctly)
  • When typing an asterisk, detect if the first character is a space (indicating a list) and remove the extra asterisk

Steps to reproduce

Asterisks

  1. Open editor
  2. Try and make a bullet list
  3. Note the extra asterisk

Back Ticks

  1. Open a file with existing (```) code blocks.
  2. Try and edit either end of the code blocks.
  3. Get buried in back ticks.

Environment

  • Version : 0.11.8
  • OS Version and name : macOS High Sierra
@ZeroX-DG ZeroX-DG added the improvement request 🔨 Issue concerns an existing feature that needs improvement. label Aug 26, 2018
@ybc37
Copy link

ybc37 commented Sep 4, 2018

👍 #2249 is also related to that.

@ZeroX-DG
Copy link
Member

You can now customize this by removing the ** from setting.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement request 🔨 Issue concerns an existing feature that needs improvement.
Projects
None yet
Development

No branches or pull requests

3 participants