Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't make new notes after failed URL to note conversion #3308

Closed
Flexo013 opened this issue Oct 23, 2019 · 1 comment · Fixed by #3313
Closed

Can't make new notes after failed URL to note conversion #3308

Flexo013 opened this issue Oct 23, 2019 · 1 comment · Fixed by #3313
Labels
bug 🐛 Issue concerns a bug. level 1 ❕ A bug that caused minor damage: App is still usable, but minor features might not work.

Comments

@Flexo013
Copy link
Contributor

Flexo013 commented Oct 23, 2019

Current behavior

The new note button stops working after entering a non existent URL to convert.

Expected behavior

A failure message appears about the previous URL to note conversion.
AND
The new note button does not stop working after a failure.

Steps to reproduce

  1. Open the new note selection (Ctrl+N).
  2. Select new markdown note from URL.
  3. Enter a non existent URL, e.g. https://www.bgvoirhbvoojwscj.com
  4. Hit Enter. (No new note is made, as expected.)
  5. Try clicking the new note button (or Ctrl+N).

Dev tools console:
image

Workaround

Reload Boostnote (Ctrl+R) to fix the issue temporarily.

Environment

  • Version : 0.13.0
  • OS Version and name : Ubuntu 16.04
@Flexo013 Flexo013 added bug 🐛 Issue concerns a bug. level 1 ❕ A bug that caused minor damage: App is still usable, but minor features might not work. labels Oct 23, 2019
@AWolf81
Copy link
Contributor

AWolf81 commented Oct 24, 2019

@Flexo013 Oh good catch. I haven't noticed that before.

I'll fix this by adding error handling to createNoteFromUrl. I'll create a PR soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Issue concerns a bug. level 1 ❕ A bug that caused minor damage: App is still usable, but minor features might not work.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants