Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localization for "Ok" word #3387

Closed
10 tasks
abnersajr opened this issue Dec 3, 2019 · 0 comments · Fixed by #3451
Closed
10 tasks

Localization for "Ok" word #3387

abnersajr opened this issue Dec 3, 2019 · 0 comments · Fixed by #3451
Labels
help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! improvement request 🔨 Issue concerns an existing feature that needs improvement.

Comments

@abnersajr
Copy link
Contributor

abnersajr commented Dec 3, 2019 •
edited
Loading

Current behavior

In the #3386 PR was added one button with the word Ok.
This button should be localized correctly for each of supported locales listed below.
Some translations were added. I wasn't sure about every locale so I decided to open this PR.

Expected behavior

Add translations for this locales. I think all the names are correct.

  • fa.json Persian
  • hu.json Hungarian
  • ja.json Japanese
  • ko.json Korean
  • pl.json Polish
  • ru.json Russian
  • th.json Thailand
  • tr.json Turkish
  • zh-CN.json Chinese
  • zh-TW.json Taiwan
@Flexo013 Flexo013 added help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! improvement request 🔨 Issue concerns an existing feature that needs improvement. labels Dec 3, 2019
@arcturus140 arcturus140 mentioned this issue Jan 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted 🆘 Pull request/issue requires extra help from the community. Check these out if you're new! improvement request 🔨 Issue concerns an existing feature that needs improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

extended language support for multiple languages arcturus140/Boostnote
2 participants
@abnersajr @Flexo013