-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export a Markdown note as PDF #2678
Conversation
I can't export notes with images. Can you check? |
@AgentEpsilon ping! |
Sorry for the long wait. Images were not working because I was passing the formatted html through a dataurl. I fixed this through a |
Hello, sorry if this question is not appropriate. How can i add this to my BoostNote? Thank you very much. Edit: I'm using Windows Built application. |
@MihaelBercic It's still in progress and hasn't been merged into the main project so you have to wait for that. Sorry for the inconvenience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Thank you. |
export note to pdf not working on the windows version.
error message: |
Description
Adds an "Export to PDF" option for Markdown notes. This feature behaves consistently with the other export options - however, due to its use of a hidden Electron window, it runs asynchronously. I've added support for output formatters to return Promises in
exportData.js
to support this feature.Additionally, I have fixed
exportFolder.js
to actually wait for all notes to export. This wasn't a problem when note exporting was synchronous, but now it seems the extra wait time was causing tests to fail.Issue fixed
Fixes #2013.
Type of changes
Checklist: