Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After select an other note now scroll to top #2890

Merged
merged 1 commit into from
Apr 28, 2019
Merged

After select an other note now scroll to top #2890

merged 1 commit into from
Apr 28, 2019

Conversation

dredav
Copy link
Contributor

@dredav dredav commented Feb 18, 2019

Issue fixed

After change the current note to an other note, scrolling to the top of the new selected note. Now thats the same behavior as it implemented at the markdown split editor.

Type of changes

  • 🔵 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔵 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Feb 18, 2019
@ZeroX-DG
Copy link
Member

Can you explain more about what you're trying to archive with this PR?

@ZeroX-DG ZeroX-DG added the needs more info ℹ️ Issue requires more information from the issue's reporter. label Mar 17, 2019
@dredav
Copy link
Contributor Author

dredav commented Mar 20, 2019

@ZeroX-DG Sure. After selecting a note, the preview should scroll to the first line of the preview. I've attach a before and after screenshot so show the behaviour.

Screenshot before

Kapture 2019-03-20 at 6 48 57

Screenshot after

Kapture 2019-03-20 at 6 52 29

@ZeroX-DG ZeroX-DG removed the needs more info ℹ️ Issue requires more information from the issue's reporter. label Apr 5, 2019
ZeroX-DG
ZeroX-DG approved these changes Apr 5, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Apr 5, 2019
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Apr 28, 2019
@Rokt33r Rokt33r added this to the v0.11.15 milestone Apr 28, 2019
@Rokt33r Rokt33r merged commit c667e14 into BoostIO:master Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.11.16
Development

Successfully merging this pull request may close these issues.
3 participants
@dredav @ZeroX-DG @Rokt33r