Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize storage ignores now tags from skipped notes #2898

Merged
merged 1 commit into from
Apr 15, 2019

Conversation

dredav
Copy link
Contributor

@dredav dredav commented Feb 23, 2019

Description

I also can only reproduce the issue #2836 that on startup all tags are listed. I've changed the behavior that only tags from notes which are not trashed will be listed.

Issue fixed

#2836

Type of changes

  • 🔵 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔵 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔵 All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Feb 24, 2019
@ZeroX-DG
Copy link
Member

Your code make all tags disappear, can you check again?

@dredav
Copy link
Contributor Author

dredav commented Mar 1, 2019

Your code make all tags disappear, can you check again?

@ZeroX-DG Sorry, I can't reproduce the disappearance of all tags (if not all tags are related to deleted notes). Do you have more informations for me?

@ZeroX-DG
Copy link
Member

ZeroX-DG commented Mar 6, 2019

Oh, that's my fault, it working fine now.

Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Mar 6, 2019
@Rokt33r Rokt33r added this to the v0.11.15 milestone Mar 20, 2019
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Apr 15, 2019
@Rokt33r Rokt33r merged commit 3634194 into BoostIO:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants