Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding TOC UI #3352

Merged
merged 4 commits into from
Dec 23, 2019
Merged

Adding TOC UI #3352

merged 4 commits into from
Dec 23, 2019

Conversation

sudomf
Copy link
Contributor

@sudomf sudomf commented Nov 11, 2019 •
edited by issuehunt-oss bot
Loading

This is a UI propose for TOC ([TOC]) tag.

Proposing solution for #2294.

image

image

Boostnote TOC

IssueHunt Summary

Referenced issues

This pull request has been submitted to:

IssueHunt has been backed by the following sponsors. Become a sponsor

@Flexo013 Flexo013 added the awaiting review ❇️ Pull request is awaiting a review. label Nov 12, 2019
@ZeroX-DG
Copy link
Member

Can you make the TOC scroll-able? because right now if you have a long list of TOC, you won't be able to click the links that overflow the TOC.

@ZeroX-DG ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Nov 15, 2019
@Flexo013 Flexo013 mentioned this pull request Nov 16, 2019
Closed
@ZeroX-DG
Copy link
Member

@maykefreitas ping

@sudomf
Copy link
Contributor Author

sudomf commented Nov 28, 2019

hey @ZeroX-DG .

Sorry for the delay. I was seek (fever) and forgot to open my GH notifications. But now I'm fine.

For sure, It can be scrollable. I'll make a commit soon as possible. Take care :)

@sudomf
Copy link
Contributor Author

sudomf commented Nov 29, 2019

hey @ZeroX-DG I just pushed 2 new commits to include scroll support. Looks good now :)

@ZeroX-DG
Copy link
Member

Thanks! Can you delete the old markdown snapshot test file for TravisCI to re-generate it please?

@sudomf
Copy link
Contributor Author

sudomf commented Nov 29, 2019 via email

@sudomf
Copy link
Contributor Author

sudomf commented Nov 29, 2019

@ZeroX-DG
done

ZeroX-DG
ZeroX-DG reviewed Nov 29, 2019
View reviewed changes
tests/lib/snapshots/markdown-test.js.md
@@ -226,39 +226,4 @@ Generated by [AVA](https://ava.li).
> Snapshot 2

`<p data-line="0">This is a &quot;QUOTE&quot;.</p>␊


## Markdown.render() should render PlantUML Ditaa correctly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you have to remove these tests?

Copy link
Contributor Author

@sudomf sudomf Nov 29, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just deleted the snapshots, to regenerate it. Do I need to do it in another way?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's strange, somehow it's still pass the test

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you deleted them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a normal delete, direct from the IDE

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh they have been moved to the top of the file 😄 look good to me then 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heheh troll

ZeroX-DG
ZeroX-DG approved these changes Dec 2, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added needs extra review 🔎 Pull request requires review from an additional reviewer. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Dec 2, 2019
@ZeroX-DG ZeroX-DG requested review from Rokt33r and removed request for Rokt33r December 2, 2019 20:31
@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed needs extra review 🔎 Pull request requires review from an additional reviewer. labels Dec 8, 2019
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Dec 23, 2019
@Rokt33r Rokt33r added this to the v0.14.0 milestone Dec 23, 2019
@Rokt33r Rokt33r merged commit 2882667 into BoostIO:master Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@sudomf @ZeroX-DG @Flexo013 @Rokt33r