Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed eslint error and integrated with prettier #3450

Merged
merged 2 commits into from
Feb 5, 2020

Conversation

ZeroX-DG
Copy link
Member

Description

This PR fixed eslint error when eslint is upgraded to v4 due to conflict with prettier. What this PR does is it integrated eslint with prettier so that the prettify process will have no conflict with the linting config. In addition, this PR also pretty the code to fix this PR: #3325

Issue fixed

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • 🔘 Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ⚪ All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Jan 29, 2020
@ZeroX-DG ZeroX-DG requested a review from Rokt33r January 29, 2020 22:23
@ZeroX-DG
Copy link
Member Author

@Rokt33r can you review this please?

Copy link
Member

@Rokt33r Rokt33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should configure prettier too!

.prettierrc

{
  "singleQuote": true,
  "semi": false,
  "jsxSingleQuote": true
}

@ZeroX-DG
Copy link
Member Author

ZeroX-DG commented Feb 4, 2020

@Rokt33r I added prettier config and run the prettier again to reduce the changes.

@Rokt33r Rokt33r added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Feb 5, 2020
@Rokt33r Rokt33r added this to the v0.15.0 milestone Feb 5, 2020
@Rokt33r Rokt33r merged commit 592aca1 into BoostIO:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved 👍 Pull request has been approved by sufficient reviewers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants