Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Vulcan UI theme #3459

Merged
merged 2 commits into from
Feb 10, 2020
Merged

add Vulcan UI theme #3459

merged 2 commits into from
Feb 10, 2020

Conversation

daiyam
Copy link
Contributor

@daiyam daiyam commented Feb 3, 2020

Description

This change adds a new very dark UI theme.
screenshot

I've redone the PR #2880 with just the necessary changes to add the new theme (since the master include all the other changes).

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • 🔘 Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@daiyam daiyam mentioned this pull request Feb 3, 2020
Closed
@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Feb 3, 2020
@ZeroX-DG
Copy link
Member

ZeroX-DG commented Feb 4, 2020

Very nice @daiyam before I approve this can you also fix a minor bug for the about title in the about section in settings?
image

@ZeroX-DG ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels Feb 4, 2020
@daiyam
Copy link
Contributor Author

daiyam commented Feb 4, 2020

@ZeroX-DG I've fixed the bug which was also present for the other themes.

ZeroX-DG
ZeroX-DG approved these changes Feb 4, 2020
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Feb 4, 2020
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Feb 10, 2020
@Rokt33r Rokt33r merged commit a496a84 into BoostIO:master Feb 10, 2020
@Rokt33r Rokt33r added this to the v0.15.0 milestone Feb 10, 2020
@daiyam daiyam deleted the theme-ui-vulcan branch February 10, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@daiyam @ZeroX-DG @Rokt33r