Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Computation Bound not explicit in existing documentation #83

Open
samueldgSBCS opened this issue Sep 19, 2022 · 1 comment
Open

Computation Bound not explicit in existing documentation #83

samueldgSBCS opened this issue Sep 19, 2022 · 1 comment

Comments

@samueldgSBCS
Copy link

The double moving windows implementation is unfit to most production implementation due to the fact that the latest data point is unexplored by the window most of the time (at the time of indicator computation).

func_arg_map = [( obs_copy[:, i:window_size + i], window_size, i, smallest_window_size, outer_increment, inner_increment, max_searches, ) for i in range(0, obs_opy_len+1, outer_increment)]
I suggest adding the option to start the iteration at (obs_opy_len % outer_increment) to make it usable in monitoring or backtest applications without branching the project.

@Joshwani
Copy link
Contributor

Thanks @samueldgSBCS would you be willing to post a draft PR with your suggestion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants