Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renderer not cleaning the right InstanceArray when id is not loaded #35

Open
Bowarc opened this issue Nov 23, 2023 · 0 comments
Open

Renderer not cleaning the right InstanceArray when id is not loaded #35

Bowarc opened this issue Nov 23, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@Bowarc
Copy link
Owner

Bowarc commented Nov 23, 2023

Context

It's fine for now as we don't update the sprite bank between the start and the end of the function

But could be a problem if we refactor

Maybe SpriteBank could return

Result<&mut InstanceArray /* requested */, &mut InstanceArray /* default */>

But that wouldn't fit with our bank trait system

@Bowarc Bowarc added the bug Something isn't working label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant