-
-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize SVGs in the Project #121
Comments
Some interesting gotchas with using SVG with an https://css-tricks.com/using-svg/
I have no idea how I didn't already know this, probably one of those things I've learned but forgot. However, this means the idea of using that method kind of goes out the window. |
So I came up with a great solution for handling SVGs that I think bridges the best ideas from both Nik and myself. The notable changes include:
The combines Nik's idea of leaning into a Svelte component, plus my idea of documenting in a single file, while creating a brand new component that follows the Skeleton conventions for props, including passthrough attributes, Tailwind styles, generic styles, and A11y support. Plus Additionally, this can still be used with standard SVG child content - you just drop any any code that would normally live between the I've documented the component here: Though please note this doc page is currently hidden from the nav bar. I would like to dogfood the component for a bit before we release it to the public. The biggest drawback is the canned set of icons are pretty limited (just what we use in components and docs). However, the ability to build your own is pretty nice. The fact the component comes with default sizes and styling is really nice. Plus there's a default icon shown if you don't provide a name or slot value. This has been merged into |
Evaluate different conventions to use to better organize component and documentation SVG icons.
See my comment here talking about this in greater detail:
#118
The text was updated successfully, but these errors were encountered: