Replies: 1 comment
-
|
Fair criticism, and thanks for the pointers in the right direction. I'll have a look at improving this script further when I get a chance. Indeed, problem solving is fun :-) |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
I just wanted to note that you open the video about your dimmer script but there is a big oversight. Given this was about fixing the oversight of hard coding things it's ironic and comical hence "Actually." - Comic Book Guy (with his index finger pointed up)
So this only works if someone is using an xrandr setup. Worse it only works if someone has a single GPU. Which is a fancy way of saying anyone using an xorg.conf and more than one XScreen or multiGPU this will fail to find/loop over all screens. My workstations are all multiGPU and xorg.conf and even my one laptop has a single GPU but I run more than one XScreen to ensure various window behaviors that you can't other wise.
You can in theory pull this off by adding an outer loop that loops over xrandr for each XScreen until it finds the $DISPLAY env is not set then break. However that might fail for special snow flake Gnome environments because they not only broke XScreen support but they also start with a 1 index rather than a 0 index. WEEEEEEE
As an extra xrandr providers will also likely need to be queried in some situations.
As for the theme of making things "just work" yes. Sadly my scripts have to deal with differing distros, xrandr vs xorg, single vs multiGPU and all the other fun stuff. Sounds like a PITA but problem solving is fun.
Beta Was this translation helpful? Give feedback.
All reactions