Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scene_manager] Add crop functionality #449

Merged
merged 2 commits into from
Nov 25, 2024
Merged

[scene_manager] Add crop functionality #449

merged 2 commits into from
Nov 25, 2024

Conversation

Breakthrough
Copy link
Owner

@Breakthrough Breakthrough commented Oct 25, 2024

Adds the ability to crop the input videos to a region specified by two points (X0, Y0) to (X1, Y1) within the frame. Resolves #302.

Open items:

  • Validate crop values passed in from config file
  • Update auto downscale calculation to use cropped size instead of original
  • Update CLI documentation

@Breakthrough Breakthrough marked this pull request as draft October 25, 2024 00:16
@Breakthrough Breakthrough force-pushed the main branch 2 times, most recently from 85d1bdd to 2c55a55 Compare November 13, 2024 03:03
@Breakthrough Breakthrough added this to the 0.6.5 milestone Nov 24, 2024
Make sure exceptions are always thrown in debug mode from the source location.
@Breakthrough Breakthrough marked this pull request as ready for review November 25, 2024 03:54
@Breakthrough Breakthrough merged commit 18c7ab8 into main Nov 25, 2024
40 checks passed
@Breakthrough Breakthrough deleted the issue-302-crop branch November 25, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support cropping / region of interest
1 participant