Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barrel duplication using Signs #80

Closed
BAD7777 opened this issue Jan 5, 2025 · 3 comments
Closed

Barrel duplication using Signs #80

BAD7777 opened this issue Jan 5, 2025 · 3 comments

Comments

@BAD7777
Copy link

BAD7777 commented Jan 5, 2025

A bug in the BreweryX plugin allows players to duplicate barrels by attaching multiple signs around a single barrel. Each sign is treated as a separate functional barrel, leading to potential exploitation and imbalance in gameplay.


Bug Description

The BreweryX plugin lets players effectively create 4 barrels from 1 by attaching signs on all sides of a barrel block.


Steps to Reproduce

  1. Place a barrel supported by the BreweryX plugin.
  2. Attach signs with barrel labels on all 4 sides of the block.
  3. Observe that each sign is recognized as a separate barrel.

Expected Behavior

A single barrel should only be linked to one sign, regardless of how many signs are placed around it.


Actual Behavior

Each of the 4 signs around the same barrel acts as an independent barrel, enabling content duplication or confusing players.


Additional Information

Screenshots:

  1. Barrel with one sign:

image

  1. Barrel with 4 signs:

image

Server Version:

  • Minecraft: 1.21.4
  • BreweryX Plugin: 3.4.6

Impact

This bug can be exploited by players to gain an unfair advantage, duplicate contents, or disrupt the intended balance of gameplay.


Suggestions for Fix

  • Limit the number of signs linked to a single barrel to one.
  • Implement a check for unique barrel identifiers during sign interactions.
@Jsinco
Copy link
Member

Jsinco commented Jan 5, 2025

Thanks for the well documented report. I’ll address this and push out an update as soon as I’m home

@Jsinco Jsinco closed this as completed in 0656db6 Jan 6, 2025
@Jsinco Jsinco reopened this Jan 6, 2025
@Jsinco
Copy link
Member

Jsinco commented Jan 6, 2025

Even though I've tested myself, I'm going to leave this issue open. Give the latest build a shot and let me know if the issue still persists: https://github.com/BreweryTeam/BreweryX/actions/runs/12627605203

@BAD7777
Copy link
Author

BAD7777 commented Jan 9, 2025

The problem has been solved. Thanks!

@BAD7777 BAD7777 closed this as completed Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants